# New commits in an open pull request

**URL:** <https://drone.discourse.group/t/new-commits-in-an-open-pull-request/11301>\
**Category:** Drone Support\
**Created:** [October 13, 2017, 5:41pm UTC](https://drone.discourse.group/t/new-commits-in-an-open-pull-request/11301 "2017-10-13T17:41:54Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![miqmago](https://avatars.discourse-cdn.com/v4/letter/m/b5e925/32.png) [@miqmago](https://drone.discourse.group/u/miqmago)\
**Post date:** [October 13, 2017, 5:41pm UTC](https://drone.discourse.group/t/new-commits-in-an-open-pull-request/11301/1 "2017-10-13T17:41:54Z")

</div>

I’ve got a gogs repo with an open pull request. The first time I opened the pull request, the webhook for drone was triggered and drone started a build.

After pushing more commits to pull request, I can see that gogs is dispatching the webhook and marks it as succsessfull. However in drone it does not trigger a new build. If I make “redelivery” from gogs, it still does not work. Is there a missing configuration or is a bug?

If I trigger the hook manually from gogs it works fine.  
If I restart the build from drone it restarts the build but does not pull the updates.

So in order to make it work again, the only solution I’ve found is to close the pull request and open a new pull request…

Also I’m looking for a plugin or something that can publish back to the pull request the status of the build (something like travis does). Is there something available?

---

<div class="post-metadata">

**Author:** ![miqmago](https://avatars.discourse-cdn.com/v4/letter/m/b5e925/32.png) [@miqmago](https://drone.discourse.group/u/miqmago)\
**Post date:** [October 13, 2017, 6:04pm UTC](https://drone.discourse.group/t/new-commits-in-an-open-pull-request/11301/2 "2017-10-13T18:04:00Z")

</div>

Also noted that the build does not correspond with the .drone.yml definition in the pull request, it seems that is getting the .drone.yml from main repo, however the git clone works fine:

```bash
git init
git remote add origin http://example.com/user/repo.git
git fetch --no-tags origin +refs/pull/5/head:
git checkout -qf FETCH_HEAD
git submodule update --init --recursive
cat .drone.yml

```

The output is:

```auto
workspace:
  base: /go

pipeline:
  pretest:
    image: node
    commands:
      - npm i
      - cp keys/TODO keys/secrets.js
  test:
    image: node
    commands:
      - npm run test
  
services:
  mongo:
    image: mongo:3.0
    command: [--smallfiles]
  node:
    image: node

```

Docker logs:

```auto
drone-server_1 | time="2017-10-13T17:51:12Z" level=error msg="pull queue item: 36: successfully removed from backup" 
drone-agent_1 | pipeline: received next execution: 36
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 36: clone
drone-agent_1 | pipeline: finish uploading logs: 36: step clone
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 36: node
drone-agent_1 | pipeline: finish uploading logs: 36: step node
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 36: test
drone-agent_1 | pipeline: finish uploading logs: 36: step test
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 36: mongo
drone-agent_1 | pipeline: finish uploading logs: 36: step mongo
drone-agent_1 | pipeline: execution complete: 36
drone-agent_1 | pipeline: cancel channel closed: 36
drone-agent_1 | pipeline: request next execution
drone-agent_1 | pipeline: cancel ping loop: 36

```

So there is no step called `pretest`, which is the main modification in the pull request.

---

<div class="post-metadata">

**Author:** ![bradrydzewski](https://yyz1.discourse-cdn.com/flex003/user_avatar/drone.discourse.group/bradrydzewski/32/3513_2.png) [@bradrydzewski](https://drone.discourse.group/u/bradrydzewski)\
**Post date:** [October 13, 2017, 6:04pm UTC](https://drone.discourse.group/t/new-commits-in-an-open-pull-request/11301/3 "2017-10-13T18:04:56Z")

</div>

This is likely because drone was looking for `synchronize` event actions instead of `synchornized` (with a `d`). We recently (2 days ago) merged [https://github.com/drone/drone/pull/2240](https://github.com/drone/drone/pull/2240) to use the updated event action. This change is available in latest.

---

<div class="post-metadata">

**Author:** ![miqmago](https://avatars.discourse-cdn.com/v4/letter/m/b5e925/32.png) [@miqmago](https://drone.discourse.group/u/miqmago)\
**Post date:** [October 13, 2017, 6:08pm UTC](https://drone.discourse.group/t/new-commits-in-an-open-pull-request/11301/4 "2017-10-13T18:08:51Z")

</div>

Ok thanks @bradrydzewski ! So hopefully it will be available in next release in docker or is there a way to update the docker in 0.7?

Is this solving also the problem of the source of `.drone.yml`? This is quite strange as normally the configuration should be taken from cloned pull request, and cloned pull request is fine… Maybe has something to do with pipeline name?

---

<div class="post-metadata">

**Author:** ![miqmago](https://avatars.discourse-cdn.com/v4/letter/m/b5e925/32.png) [@miqmago](https://drone.discourse.group/u/miqmago)\
**Post date:** [October 13, 2017, 6:12pm UTC](https://drone.discourse.group/t/new-commits-in-an-open-pull-request/11301/5 "2017-10-13T18:12:20Z")

</div>

Note that when merging the pull request, the new `.drone.yml` config is being used and the log output is:

```auto
drone-agent_1 | pipeline: received next execution: 43
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 43: clone
drone-agent_1 | pipeline: finish uploading logs: 43: step clone
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 43: node
drone-agent_1 | pipeline: finish uploading logs: 43: step node
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 43: pretest
drone-agent_1 | pipeline: finish uploading logs: 43: step pretest
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 43: test
drone-agent_1 | pipeline: finish uploading logs: 43: step test
drone-agent_1 | pipeline: finish uploading logs: application/json+logs: step 43: mongo
drone-agent_1 | pipeline: finish uploading logs: 43: step mongo

```

---

<div class="post-metadata">

**Author:** ![bradrydzewski](https://yyz1.discourse-cdn.com/flex003/user_avatar/drone.discourse.group/bradrydzewski/32/3513_2.png) [@bradrydzewski](https://drone.discourse.group/u/bradrydzewski)\
**Post date:** [October 13, 2017, 6:35pm UTC](https://drone.discourse.group/t/new-commits-in-an-open-pull-request/11301/6 "2017-10-13T18:35:40Z")

</div>

> [@On another topic](https://drone.discourse.group/t/868/4):
>
> Is this solving also the problem of the source of .drone.yml? This is quite strange as normally the configuration should be taken from cloned pull request

The issue is that drone uses the API to fetch the yaml file. Gogs does not allow fetching a file via the API using the pull request ref. Note that this is not an issue for other providers (Github, Gitlab, etc). So this is a known limitation of Gogs, and there is nothing we can do about it within drone until their API provides this capability.
