GitHub Deployments & Drone 1.0

Drone Support
1

It looks like Drone 1.0 is no longer being triggered by GH deployments? First, it added the webhook to GH without the option to receive deployment events, and drone doesn’t give me the option to enable that event. If I manually add it to the hook on the GH side, Drone still ignores it.

Public example with cloud drone: https://github.com/fsouza/drone-gh-deploy/blob/master/.drone.yml

Delivered payload from GH: https://gist.github.com/fsouza/4092e2541a05ef38f252ed50196ee385

Is it something that isn’t implemented yet? Or will it not be available in Drone 1.0? Or am I doing something wrong? :smiley:

Thanksss

2

ah good catch, I had not added deployment events to 1.0 (slipped my mind because they are GitHub-only). I have re-added them to our package that abstracts source control providers [1] and added some preliminary logic to try and identify branch vs tag and set the ref accordingly [2]. I will try and see if this can be included in the next 1.0 release candidate.

[1] https://github.com/drone/go-scm
[2] https://github.com/drone/go-scm/commit/f5fde5b45c41e81fec043dddcb167d1d3083c2c4

3

@bradrydzewski that’s awesome, thank you very much for the quick fix!

4

Hi there,

we’re also using this and are happy to hear that drone 1 will support this! <3
(Tried to inquire about this here: Drone 1.0.0-rc5 - deployment builds )

How can we use this? I think a new drone v1 image/tag will have to be made/released correct?

Many thanks in advance,

Daniel