Kubernetes runner (latest) ignoring step resource requests

Drone Support
1

Hi,
yesterday I deployed latest kubernetes-runner with tag latest and we discovered that it’s ignoring resource requests defined in individual steps. This was working on previous stable release 1.0.0-beta.6.

kind: pipeline
type: kubernetes
name: dashboard

platform:
  os: linux
  arch: amd64

clone:
  depth: 1

steps:
- name: build-dashboard
  image: node:14
  commands:
  - make build-dashboard docker=false
  environment:
    SENTRY_PROJECT: front-app
  resources:
    requests:
      cpu: 3000
      memory: 12GiB

But in the kubernetes pod definition there’re only requests defined by drone-runner envs

  DRONE_RESOURCE_REQUEST_CPU: 3000
  DRONE_RESOURCE_REQUEST_MEMORY: 2048MiB

Could you please look into that?
Thanks.

2

resource requests are no longer defined for individual steps. See the below thread for the updated syntax as well as the rationale for this change

http://discuss.harness.io/t/strategy-for-pod-cpu-settings-on-kubernetes-runner/7813/4?u=bradrydzewski

3

Well in that case, would it be possible to update drone/cli to support translating resource definition at the pipeline level from jsonnet to YAML?
I compile it with docker image drone/cli:1.3.0
and command: jsonnet --stream --format=true

This is the jsonnet definition:

pipeline(SOURCE): {
    kind: 'pipeline',
    type: 'kubernetes',
    name: SOURCE.name(),
    trigger: {
      event: ['push', 'tag'],
      paths: SOURCE.trigger_path(),
    },
    steps: SOURCE.steps(),
    services: SOURCE.services(),
    resources: {
      requests: {
        cpu: 3000,
        memory: '1024MiB',
      }
    },
  },

I’d still prefer to use YAML then JSON as output as there’s been some problems with drone processing the JSON format.

The translation from jsonnet to YAML was/is working for resource definition at STEP level but it’s not translating working for resource definition at PIPELINE level.
Thanks.

4

@bradrydzewski may I bring this back to attention?

5

Thank you @bradrydzewski!
This issue was solved with release of Drone/cli version 1.3.1

Now it’s possible to compile Jsonnet definition to YAML with included Kubernetes definitions like Resource requests and limits or nodeSelectors.